> On Dec. 18, 2016, 11:46 p.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.hpp, lines 477-478 > > <https://reviews.apache.org/r/53096/diff/9/?file=1582260#file1582260line477> > > > > Update the comment per the comment about the role of the method. > > > > ``` > > // Helper to update the total resources in the allocator and each of > > the sorters. > > ``` > > Anindya Sinha wrote: > Not each of the sorters but only the role and quota sorters, since the > framework sorter's total is a subset of slave's total resources. Correct?
Ah you are right. However because of this it might make sense to name the method more explcitly, i.e., `updateSlaveTotal`, as in, frameworkSorter's total is not the agent's total? I'll comment further in the review. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53096/#review159578 ----------------------------------------------------------- On Jan. 9, 2017, 2:37 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53096/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2017, 2:37 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6444 > https://issues.apache.org/jira/browse/MESOS-6444 > > > Repository: mesos > > > Description > ------- > > We maintain a single copy of shared resource in the role and quota > sorter's total resources. So, when we update these resources, we > remove the previous resources at this agent and add the new resources > at this agent. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > a6424d624864155e1c87a28a63b784512c5c8722 > src/master/allocator/mesos/hierarchical.cpp > 91b1ec43940a788459f045ca4a4b82d4e8373bca > src/tests/persistent_volume_tests.cpp > 8198b6b5ad323d17835ba067c7ff3d34ef948125 > > Diff: https://reviews.apache.org/r/53096/diff/ > > > Testing > ------- > > Tests passed. > > > Thanks, > > Anindya Sinha > >
