----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55893/#review163111 -----------------------------------------------------------
I think that your patch need depend on /r/51027 , also in `Testing Done` section, can you please make the test repeat or use `--gtest_repeat=-1 --gtest_break_on_failure` to make sure the test is not flaky? src/tests/oversubscription_tests.cpp (line 507) <https://reviews.apache.org/r/55893/#comment234561> How about s/offer1/offer as here you only have one such variable. src/tests/oversubscription_tests.cpp (line 543) <https://reviews.apache.org/r/55893/#comment234562> How about following? ``` // The latest resource estimate should match the total offered resources. ``` This can also make the comments match `resources2 and resources3`. - Guangya Liu On 一月 24, 2017, 9:52 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55893/ > ----------------------------------------------------------- > > (Updated 一月 24, 2017, 9:52 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > This is another test fix in the chain. > > > Diffs > ----- > > src/tests/oversubscription_tests.cpp > 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 > > Diff: https://reviews.apache.org/r/55893/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
