> On Jan. 26, 2017, 1:40 a.m., Guangya Liu wrote: > > src/tests/oversubscription_tests.cpp, line 559 > > <https://reviews.apache.org/r/55893/diff/1/?file=1613785#file1613785line559> > > > > How about following? > > > > ``` > > // The latest resource estimate should match the total offered > > resources. > > ``` > > > > This can also make the comments match `resources2 and resources3`.
You mean match `EXPECT_EQ(resources2, resources3);`? So with `EXPECT_EQ`, the signature is `EXPECT_EQ(expected, actual);` so its indeed resources3 (offered resources, actual) matches resources2 (the estimate, expected). > On Jan. 26, 2017, 1:40 a.m., Guangya Liu wrote: > > src/tests/oversubscription_tests.cpp, line 512 > > <https://reviews.apache.org/r/55893/diff/1/?file=1613785#file1613785line512> > > > > How about s/offer1/offer as here you only have one such variable. True but on the other hand, offer1 matches resources1, as in, the first offer. If I s/offerId/offerId1/ I guess this would be more clear. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55893/#review163111 ----------------------------------------------------------- On Jan. 24, 2017, 1:52 p.m., Jiang Yan Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55893/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 1:52 p.m.) > > > Review request for mesos, Benjamin Mahler, Guangya Liu, and Jacob Janco. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > This is another test fix in the chain. > > > Diffs > ----- > > src/tests/oversubscription_tests.cpp > 22ae069ab71c82c6a6e2f5783b13ebd74a9ccf25 > > Diff: https://reviews.apache.org/r/55893/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Jiang Yan Xu > >
