----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56001/#review163190 -----------------------------------------------------------
Nice catch! As per our offline discussion, can you modify an existing test for both the default/docker executor to also check if the `status` field is set, it shouldn't have a non-zero value. src/docker/executor.cpp (lines 814 - 815) <https://reviews.apache.org/r/56001/#comment234651> Can you add a comment here for posterity as to why this is needed? src/docker/executor.cpp (line 817) <https://reviews.apache.org/r/56001/#comment234653> Not yours, but we should have a comment here too as to why we need an explicit `finalize()` here in a separate patch. src/launcher/default_executor.cpp (line 1142) <https://reviews.apache.org/r/56001/#comment234652> Ditto. - Anand Mazumdar On Jan. 26, 2017, 10:28 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56001/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 10:28 p.m.) > > > Review request for mesos, Anand Mazumdar, Gilbert Song, and Jie Yu. > > > Bugs: MESOS-6989 > https://issues.apache.org/jira/browse/MESOS-6989 > > > Repository: mesos > > > Description > ------- > > The addition of `process::finalize` at the end of some binaries > led to some segfaulting at the end of the binaries' lifetimes. > This is mostly due calling destructors of libprocess actor > wrappers, which require an initialized libprocess to function. > > This commit explicitly calls the destructors on the default > and docker executor actors prior to calling `process::finalize`. > > > Diffs > ----- > > src/docker/executor.cpp f353341c9509532653e2ef8802f20259ce67930c > src/launcher/default_executor.cpp a03794934adb93868734f8cf00b337a1bff9b5ab > > Diff: https://reviews.apache.org/r/56001/diff/ > > > Testing > ------- > > sudo src/mesos-tests --gtest_filter="*ROOT*DOCKER*" --verbose > > Checked that all executors exited with status code 0, rather than 11. > > > Thanks, > > Joseph Wu > >
