----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55967/#review163398 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (line 3933) <https://reviews.apache.org/r/55967/#comment234859> Need call `allocation.allocate("*");` here to make sure the agent can be added successfully. src/tests/hierarchical_allocator_tests.cpp (line 3934) <https://reviews.apache.org/r/55967/#comment234855> Need call `allocation.allocate("*");` here to make sure the agent can be added successfully. src/tests/hierarchical_allocator_tests.cpp (line 3934) <https://reviews.apache.org/r/55967/#comment234856> Need call `allocation.allocate("*");` here to make sure the agent can be added successfully. src/tests/hierarchical_allocator_tests.cpp (line 4084) <https://reviews.apache.org/r/55967/#comment234858> Need call `allocation.allocate("*");` here to make sure the agent can be added successfully. src/tests/hierarchical_allocator_tests.cpp (lines 4188 - 4189) <https://reviews.apache.org/r/55967/#comment234846> Why moving this here? src/tests/hierarchical_allocator_tests.cpp (line 4243) <https://reviews.apache.org/r/55967/#comment234857> Need call `allocation.allocate("*");` here to make sure the agent can be added successfully. - Guangya Liu On 一月 26, 2017, 12:46 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55967/ > ----------------------------------------------------------- > > (Updated 一月 26, 2017, 12:46 a.m.) > > > Review request for mesos, Guangya Liu and Michael Park. > > > Repository: mesos > > > Description > ------- > > Update the allocator unit tests to reflect MULTI_ROLE support. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/55967/diff/ > > > Testing > ------- > > make check > > note that the rest of the tests do not pass until after my subsequent patches > > > Thanks, > > Benjamin Mahler > >
