> On Jan. 28, 2017, 1:16 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 3942 > > <https://reviews.apache.org/r/55967/diff/1/?file=1616016#file1616016line3942> > > > > Need call `allocation.allocate("*");` here to make sure the agent can > > be added successfully.
Good catch Guangya! Unfortunately I didn't run the benchmark, I wish they ran in a reasonable amount of time :( > On Jan. 28, 2017, 1:16 p.m., Guangya Liu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 4093 > > <https://reviews.apache.org/r/55967/diff/1/?file=1616016#file1616016line4093> > > > > Need call `allocation.allocate("*");` here to make sure the agent can > > be added successfully. Thanks! Needs to be role1 though FWICT. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55967/#review163398 ----------------------------------------------------------- On Jan. 26, 2017, 12:46 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55967/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2017, 12:46 a.m.) > > > Review request for mesos, Guangya Liu and Michael Park. > > > Repository: mesos > > > Description > ------- > > Update the allocator unit tests to reflect MULTI_ROLE support. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 1edd0ecc8a93cd41532e1cf3641f67c780ab23a5 > > Diff: https://reviews.apache.org/r/55967/diff/ > > > Testing > ------- > > make check > > note that the rest of the tests do not pass until after my subsequent patches > > > Thanks, > > Benjamin Mahler > >
