----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54712/#review163557 -----------------------------------------------------------
src/linux/ldd.cpp (lines 29 - 32) <https://reviews.apache.org/r/54712/#comment235116> With the iterative approach I don't see the need to pass the `dependencies` hashset in? Maybe we don't even need `collectDependencies`, everything can be put inside `ldd`. src/linux/ldd.cpp (line 34) <https://reviews.apache.org/r/54712/#comment235118> Can we define what a `candidate` means here, espeically when it's alongside the locally defined `dependencies`? Like: ``` hashset<string> dependencies; // Dependencies that have been discovered but yet to be validated and processed. vector<string> candidates; ``` src/linux/ldd.cpp (lines 40 - 42) <https://reviews.apache.org/r/54712/#comment235119> If we are traversing in a particular order, say BFS, maybe pick from `front()`? Also a brief comment stating that it is BFS? src/linux/ldd.cpp (line 74) <https://reviews.apache.org/r/54712/#comment235121> s/was/is/? - Jiang Yan Xu On Dec. 19, 2016, 3:23 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54712/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 3:23 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Use the stout ELF parser to implement an ldd() API that recursively > gathers the link dependencies of a given program. > > > Diffs > ----- > > src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 > src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b > src/linux/ldd.hpp PRE-CREATION > src/linux/ldd.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54712/diff/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >
