----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54712/#review163904 -----------------------------------------------------------
src/linux/ldd.hpp (line 30) <https://reviews.apache.org/r/54712/#comment235418> Sorry it only occured to me after the review but can we remove the given `path` from the result set to match `ldd` semantics? Yes this method was originally not `ldd` and it doesn't have to be. But for something that's "pretty much" ldd, if we implement it as `ldd` and call it `ldd`, it's much easier for people to understand, right? :) - Jiang Yan Xu On Dec. 19, 2016, 3:23 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54712/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 3:23 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Use the stout ELF parser to implement an ldd() API that recursively > gathers the link dependencies of a given program. > > > Diffs > ----- > > src/CMakeLists.txt c8d4260c03d8cdee1951a50d293e9fdabcd2cf84 > src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b > src/linux/ldd.hpp PRE-CREATION > src/linux/ldd.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54712/diff/ > > > Testing > ------- > > sudo make check (Fedora 25) > > > Thanks, > > James Peach > >
