> On Jan. 31, 2017, 7:39 a.m., Jiang Yan Xu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1813-1823 > > <https://reviews.apache.org/r/52534/diff/4/?file=1619670#file1619670line1813> > > > > Actually no need to disambiguate now that we only have one `_expire`.
Will have to disambiguate the overloaded `expire()` - Jacob ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review163633 ----------------------------------------------------------- On Jan. 31, 2017, 1:47 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52534/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2017, 1:47 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan > Xu. > > > Bugs: MESOS-6904 > https://issues.apache.org/jira/browse/MESOS-6904 > > > Repository: mesos > > > Description > ------- > > - With an asynchronous `batch()` allocation, > this ensures that filters do not expire > before the next allocation. > - This patch should be reverted when allocation > occurs on resource recovery. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2cda3e311ce339d82065d68de83e86439fa192ff > src/master/allocator/mesos/hierarchical.cpp > f471b6848bebae601a7a0509e9c6ad5eab4fa4a2 > > Diff: https://reviews.apache.org/r/52534/diff/ > > > Testing > ------- > > With https://reviews.apache.org/r/51027/: > > GTEST_FILTER="-*SmallOfferFilter*" make check -j8 > > > Thanks, > > Jacob Janco > >
