----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52534/#review158879 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (lines 1077 - 1078) <https://reviews.apache.org/r/52534/#comment229692> If you want to add such a TODO, it should probably live close to `recoverResources()`. - Alexander Rukletsov On Dec. 12, 2016, 5:04 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52534/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 5:04 p.m.) > > > Review request for mesos, Alexander Rukletsov, Benjamin Mahler, and Jiang Yan > Xu. > > > Repository: mesos > > > Description > ------- > > - With an asynchronous `batch()` allocation, > this ensures that filters do not expire > before the next allocation. > - This patch should be reverted when allocation > occurs on resource recovery. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > 2c31471ee0f5d6836393bf87ff9ecfd8df835013 > src/master/allocator/mesos/hierarchical.cpp > c8f9492ee1b69e125a1e841116d22a578a9b524e > > Diff: https://reviews.apache.org/r/52534/diff/ > > > Testing > ------- > > With https://reviews.apache.org/r/51027/: > > GTEST_FILTER="-*SmallOfferFilter*" make check -j8 > > > Thanks, > > Jacob Janco > >
