----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54878/#review163906 -----------------------------------------------------------
Ship it! src/tests/ldd_tests.cpp (line 47) <https://reviews.apache.org/r/54878/#comment235419> No big deal, but we could just do `dependencies->contains()` which is shorter. - Jiang Yan Xu On Feb. 1, 2017, 3:52 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54878/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 3:52 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Add some simple ldd() tests. > > > Diffs > ----- > > src/Makefile.am 6c9be54fe0ce3faaa26e2f090773d1b77bb6e430 > src/tests/CMakeLists.txt 44b74ee591b14d7d69bc0c03c26167b33eaa789c > src/tests/ldd_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54878/diff/ > > > Testing > ------- > > make check (Fedora 25). > > > Thanks, > > James Peach > >
