----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54878/#review163643 -----------------------------------------------------------
Fix it, then Ship it! src/tests/ldd_tests.cpp (line 48) <https://reviews.apache.org/r/54878/#comment235123> Not that there's anything wrong with it but we rarely do this, especially when this output provides no additional runtime info on why this expectation failed. Just using a comment is more typical. Also this raises the question of "why only do it for this check"? src/tests/ldd_tests.cpp (line 58) <https://reviews.apache.org/r/54878/#comment235125> Nit: `strings::startsWith` it a bit cleaner and I don't need to count the number of chars? :) src/tests/ldd_tests.cpp (line 62) <https://reviews.apache.org/r/54878/#comment235127> Ditto about `<<`. - Jiang Yan Xu On Dec. 19, 2016, 3:22 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54878/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2016, 3:22 p.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > Add some simple ldd() tests. > > > Diffs > ----- > > src/Makefile.am 0f62ec70816e8b48e19d35036285656a6e7cd02b > src/tests/CMakeLists.txt 731d58c5e45e1e5f2f47155ebe556a97fb443044 > src/tests/ldd_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54878/diff/ > > > Testing > ------- > > make check (Fedora 25). > > > Thanks, > > James Peach > >
