----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56174/#review163930 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 287) <https://reviews.apache.org/r/56174/#comment235450> LGTM, do we have tests for the local puller already? Will be good to have a test around this. - Timothy Chen On Feb. 1, 2017, 3:17 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56174/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 3:17 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-7045 > https://issues.apache.org/jira/browse/MESOS-7045 > > > Repository: mesos > > > Description > ------- > > If a layer is already in the store, there's no need to extract it. > `RegistryPuller` already does this and `Store` is ready for such puller > behaviour. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > ee391af898886bff9e5b911697f725c5ea53ebd8 > > Diff: https://reviews.apache.org/r/56174/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Ilya Pronin > >
