> On Feb. 2, 2017, 3:39 a.m., Timothy Chen wrote: > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp, line 287 > > <https://reviews.apache.org/r/56174/diff/1/?file=1621326#file1621326line287> > > > > LGTM, do we have tests for the local puller already? Will be good to > > have a test around this.
I added a test for this feature in `LocalPuller`. And a test for `Store` as a separate RR: https://reviews.apache.org/r/56284/ - Ilya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56174/#review163930 ----------------------------------------------------------- On Feb. 3, 2017, 6:07 p.m., Ilya Pronin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56174/ > ----------------------------------------------------------- > > (Updated Feb. 3, 2017, 6:07 p.m.) > > > Review request for mesos, Jie Yu and Timothy Chen. > > > Bugs: MESOS-7045 > https://issues.apache.org/jira/browse/MESOS-7045 > > > Repository: mesos > > > Description > ------- > > If a layer is already in the store, there's no need to extract it. > `RegistryPuller` already does this and `Store` is ready for such puller > behaviour. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > ee391af898886bff9e5b911697f725c5ea53ebd8 > src/tests/containerizer/provisioner_docker_tests.cpp > af9987f88205d00d091f35fa734d5667506aaffd > > Diff: https://reviews.apache.org/r/56174/diff/ > > > Testing > ------- > > Added a test verifying that local puller will skip layes that are already in > the store. Ran `make check`. > > > Thanks, > > Ilya Pronin > >
