----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review164172 -----------------------------------------------------------
Fix it, then Ship it! Just a few nits. src/tests/containerizer/rootfs.cpp (lines 62 - 63) <https://reviews.apache.org/r/53791/#comment235767> This is not a valid indentation style. ``` return Error( "Failed to resolve '" + path + "': " + target.error()); ``` or ``` return Error("Failed to resolve '" + path + "': " + target.error()); ``` here and below. src/tests/containerizer/rootfs.cpp (line 79) <https://reviews.apache.org/r/53791/#comment235811> In Mesos full spelling of variable names is prefered. s/src/source/ s/dst/destination/ src/tests/containerizer/rootfs.cpp (lines 89 - 90) <https://reviews.apache.org/r/53791/#comment235828> Given the comment above: `destinationDirectory` is at least no worse than: https://github.com/apache/mesos/blob/3a537a1d18e500fb1efe2f4d4f0718fb25c51848/src/launcher/fetcher.cpp#L65 `destinationFullPath` slightly better? (i.e., what are the differences between destination vs. destinationPath?) - Jiang Yan Xu On Feb. 2, 2017, 9:32 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53791/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 9:32 a.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > The dependencies for the programs we need in the Linux root > filesystem vary over time and across distributions. Since Stout > has support for parsing the library dependencies of ELF binaries, > use this to collect the necessary dependencies when constructing > a root filesystem for the tests. > > > Diffs > ----- > > src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138 > src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e > > Diff: https://reviews.apache.org/r/53791/diff/ > > > Testing > ------- > > sudo make check (Fedora 24) > > > Thanks, > > James Peach > >
