----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53791/#review163834 -----------------------------------------------------------
src/tests/containerizer/rootfs.hpp (line 50) <https://reviews.apache.org/r/53791/#comment235333> `copy()` would normally take a const reference to something and return a copy of that. Since this is not what we are doing, best not to use that name. src/tests/containerizer/rootfs.cpp (lines 61 - 63) <https://reviews.apache.org/r/53791/#comment235322> It's better to format consistently than to micro-manage line lengths. src/tests/containerizer/rootfs.cpp (line 90) <https://reviews.apache.org/r/53791/#comment235324> What are you asking for here? This can fail for a number of reasons and `errno` describes them. Squashing that to a fixed string would be misleading. - James Peach On Feb. 1, 2017, 11:51 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53791/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 11:51 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Kevin Klues, and Jiang Yan Xu. > > > Bugs: MESOS-6588 > https://issues.apache.org/jira/browse/MESOS-6588 > > > Repository: mesos > > > Description > ------- > > The dependencies for the programs we need in the Linux root > filesystem vary over time and across distributions. Since Stout > has support for parsing the library dependencies of ELF binaries, > use this to collect the necessary dependencies when constructing > a root filesystem for the tests. > > > Diffs > ----- > > src/tests/containerizer/rootfs.hpp 9648638c1d4b1f1c49708e058e9b930c5ae32138 > src/tests/containerizer/rootfs.cpp f11f126fa4f3130b6778bfe7e7d0f025a638f06e > > Diff: https://reviews.apache.org/r/53791/diff/ > > > Testing > ------- > > sudo make check (Fedora 24) > > > Thanks, > > James Peach > >
