----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review164278 -----------------------------------------------------------
Fix it, then Ship it! 3rdparty/stout/include/Makefile.am (line 83) <https://reviews.apache.org/r/54592/#comment235950> Should this be fixed? 3rdparty/stout/include/stout/os/lseek.hpp (line 22) <https://reviews.apache.org/r/54592/#comment235951> Should we include `try.hpp` and `error.hpp` here also? 3rdparty/stout/include/stout/os/lseek.hpp (line 26) <https://reviews.apache.org/r/54592/#comment235952> Since the Windows signature uses `long` instead of `off_t`, I wonder if it is appropriate to do a `static_assert` to verify they're appropriately convertable? - Alex Clemmer On Feb. 5, 2017, 1:38 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54592/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2017, 1:38 a.m.) > > > Review request for mesos, Daniel Pravat and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Introduced an `os::lseek` abstraction in stout. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 > 3rdparty/stout/include/stout/os.hpp > ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 > 3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54592/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
