> On Feb. 5, 2017, 1:03 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/os/lseek.hpp, line 26 > > <https://reviews.apache.org/r/54592/diff/6/?file=1624400#file1624400line26> > > > > Since the Windows signature uses `long` instead of `off_t`, I wonder if > > it is appropriate to do a `static_assert` to verify they're appropriately > > convertable?
Well, we'd get an error if it's not anyway. Specifically, in the `_lseek` call. - Michael ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54592/#review164278 ----------------------------------------------------------- On Feb. 4, 2017, 5:38 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54592/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2017, 5:38 p.m.) > > > Review request for mesos, Daniel Pravat and Joris Van Remoortere. > > > Repository: mesos > > > Description > ------- > > Introduced an `os::lseek` abstraction in stout. > > > Diffs > ----- > > 3rdparty/stout/include/Makefile.am 53d04a9b6c4a0d8b35d3c84ef24d619fdb8a2c82 > 3rdparty/stout/include/stout/os.hpp > ed6fec3ac1c1f9dfb0585178401f4b552822a0a1 > 3rdparty/stout/include/stout/os/lseek.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/54592/diff/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
