----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54650/#review164466 -----------------------------------------------------------
Ship it! src/master/validation.cpp (line 1462) <https://reviews.apache.org/r/54650/#comment236205> I created https://issues.apache.org/jira/browse/MESOS-7072 to clean up the use of `T*` for in parameters here. src/master/validation.cpp (line 1473) <https://reviews.apache.org/r/54650/#comment236204> Small nit: `role()` returns a `const string&`, and we just store the result in `_role` to have a convenient short-hand. If we'd bind the result of `role()` to a `const string&` instead of creating a copy we could avoid needless creation of strings for all but the first element (where we store a copy in `role`). - Benjamin Bannier On Feb. 7, 2017, 3:10 a.m., Jay Guo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54650/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 3:10 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Guangya Liu. > > > Bugs: MESOS-6637 > https://issues.apache.org/jira/browse/MESOS-6637 > > > Repository: mesos > > > Description > ------- > > For a multi-role framework, it may receive offers for different roles > in that framework. However, we disallow multiple offers with different > roles being accepted in single ACCEPT call. > > > Diffs > ----- > > src/master/validation.cpp 2beee167439fe39d4f595c6b858fb6175321fbcd > > Diff: https://reviews.apache.org/r/54650/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jay Guo > >
