----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56339/#review164529 -----------------------------------------------------------
src/tests/containerizer/docker_archive.hpp (lines 101 - 105) <https://reviews.apache.org/r/56339/#comment236291> I think this only applies to 'Task'. If the image is used by the executor, then this will certainly break them? - Jie Yu On Feb. 6, 2017, 10:04 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56339/ > ----------------------------------------------------------- > > (Updated Feb. 6, 2017, 10:04 p.m.) > > > Review request for mesos, Jie Yu and Kevin Klues. > > > Bugs: MESOS-7027 > https://issues.apache.org/jira/browse/MESOS-7027 > > > Repository: mesos > > > Description > ------- > > This subtly modifies all tests using the `docker/runtime` isolator > to fail if environment variables from inside the DockerArchive > are passed into the Mesos executor's environment. This applies > for all executors (default, command, and docker), but mainly > affects the command executor. > > The environment variables are `LD_LIBRARY_PATH`, `LIBPROCESS_IP`, > and `LIBPROCESS_PORT`; all of which are set to `invalid`. This > either causes linking problems or will force libprocess to exit. > > > Diffs > ----- > > src/tests/containerizer/docker_archive.hpp > b36dbdba7acf0587e18aced3581f68a1269b04d2 > > Diff: https://reviews.apache.org/r/56339/diff/ > > > Testing > ------- > > This causes some tests to fail, particularly many of the > `DockerRuntimeIsolatorTest` in `runtime_isolator_tests.cpp`. > > A variety of other tests which use `DockerArchive` will also fail. > > > Thanks, > > Joseph Wu > >
