-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56339/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 5:40 p.m.)
Review request for mesos, Jie Yu and Kevin Klues.
Changes
-------
Updated code to allow future tests of custom executors to disable the invalid
environment variables, if needed.
Bugs: MESOS-7027
https://issues.apache.org/jira/browse/MESOS-7027
Repository: mesos
Description
-------
This subtly modifies all tests using the `docker/runtime` isolator
to fail if environment variables from inside the DockerArchive
are passed into the Mesos executor's environment. This applies
for all executors (default, command, and docker), but mainly
affects the command executor.
The environment variables are `LD_LIBRARY_PATH`, `LIBPROCESS_IP`,
and `LIBPROCESS_PORT`; all of which are set to `invalid`. This
either causes linking problems or will force libprocess to exit.
Diffs (updated)
-----
src/tests/containerizer/docker_archive.hpp
b36dbdba7acf0587e18aced3581f68a1269b04d2
Diff: https://reviews.apache.org/r/56339/diff/
Testing
-------
This causes some tests to fail, particularly many of the
`DockerRuntimeIsolatorTest`:
```
HealthCheckTest.ROOT_HealthyTaskWithContainerImage
ProvisionerDockerPullerTest.ROOT_LocalPullerSimpleCommand
CgroupsIsolatorTest.ROOT_CGROUPS_PERF_NET_CLS_UserCgroup
LinuxFilesystemIsolatorMesosTest.ROOT_ChangeRootFilesystemCommandExecutor
LinuxFilesystemIsolatorMesosTest.ROOT_ChangeRootFilesystemCommandExecutorWithHostVolumes
LinuxFilesystemIsolatorMesosTest.ROOT_ChangeRootFilesystemCommandExecutorPersistentVolume
LinuxFilesystemIsolatorMesosTest.ROOT_RecoverOrphanedPersistentVolume
LinuxFilesystemIsolatorMesosTest.ROOT_SandboxEnvironmentVariable
DockerRuntimeIsolatorTest.ROOT_DockerDefaultCmdLocalPuller
DockerRuntimeIsolatorTest.ROOT_DockerDefaultEntryptLocalPuller
DockerRuntimeIsolatorTest.ROOT_NestedDockerDefaultCmdLocalPuller
TestParam/LinuxCapabilitiesIsolatorTest.ROOT_Ping/11
TestParam/LinuxCapabilitiesIsolatorTest.ROOT_Ping/13
TestParam/LinuxCapabilitiesIsolatorTest.ROOT_Ping/15
```
Thanks,
Joseph Wu
