-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56362/
-----------------------------------------------------------
(Updated Feb. 7, 2017, 6:54 p.m.)
Review request for mesos, Alex Clemmer and Joseph Wu.
Changes
-------
Add `#ifdef __linux__` guard around `systemd` back.
Bugs: MESOS-6892
https://issues.apache.org/jira/browse/MESOS-6892
Repository: mesos
Description (updated)
-------
Instead of deriving `WindowsLauncher` from `PosixLauncher`,
this commit implements a separate `WindowsLauncher` derived
from `Launcher` parallel to the `PosixLauncher`.
The purpose of this is to setup for refactoring the `WindowsLauncher`
into a `Launcher` that uses Windows' "Job Objects,"
which are similar to Linux's cgroups, and enable us to reason
about a group of processes. It is necessary to do this in the
`WindowsLaucher` because the current implementation uses the POSIX
idea of a process hierarchy to list and kill all processes
associated with a task. We have found this model to not work on
Windows, and the solution is to use Job Objects.
Because this is preparation work, it is a straight copy of the
current "working" implementation. That is, the `PosixLauncher`
has been copied to create the `WindowsLauncher`, instead of
the latter deriving the former.
Diffs (updated)
-----
src/CMakeLists.txt c09bcde3c14a73ab0b296c400f79f6a775da2470
src/slave/containerizer/mesos/containerizer.cpp
d2b4f75a55dbe4746bc2dfc180335fa831a554ef
src/slave/containerizer/mesos/launcher.hpp
79f6eea0ee8e564e90b36208672df150dbc5d540
src/slave/containerizer/mesos/launcher.cpp
5114c130efbfb252dde1e85c081f5174e66f57af
src/slave/containerizer/mesos/windows_launcher.hpp PRE-CREATION
src/slave/containerizer/mesos/windows_launcher.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/56362/diff/
Testing
-------
Thanks,
Andrew Schwartzmeyer
