----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56376/#review164638 -----------------------------------------------------------
src/tests/hierarchical_allocator_tests.cpp (lines 203 - 205) <https://reviews.apache.org/r/56376/#comment236405> IMO, since this is for testing purpose, we probably don't need to rigidly require test writers to construct frameworkInfo with `MULTI_ROLE` capability. If `createFrameworkInfo` is called with multiple roles, we could simply add `MULTI_ROLE` implicitly. And one could still explicitly add `MULTI_ROLE` to capabilities with a single role. Then we don't need to change existing test cases and avoid future confusion. What do you think? - Jay Guo On Feb. 7, 2017, 6:10 p.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56376/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 6:10 p.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > ------- > > Updated allocator test to support create multi role framework. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > c681d03c3f94f7d071143366a5aad0421108ebec > > Diff: https://reviews.apache.org/r/56376/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
