> On 二月 13, 2017, 11:31 p.m., Benjamin Mahler wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 221-222 > > <https://reviews.apache.org/r/56376/diff/2/?file=1630723#file1630723line221> > > > > You should probably do this only if the caller did not specify the > > multi role capability explicitly? Or FAIL the test if the caller specifies > > it with a message saying that we mandate that these tests are all using > > MULTI_ROLE, so no need to pass it.
OK, I will do this only if the caller did not specify the multi role capability explicitly, this option seems simple and also easy to be used by others when creating multi role frameworks. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56376/#review165402 ----------------------------------------------------------- On 二月 11, 2017, 10:09 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56376/ > ----------------------------------------------------------- > > (Updated 二月 11, 2017, 10:09 a.m.) > > > Review request for mesos, Benjamin Mahler and Jay Guo. > > > Bugs: MESOS-6638 > https://issues.apache.org/jira/browse/MESOS-6638 > > > Repository: mesos > > > Description > ------- > > Updated allocator test to support create multi role framework. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > a866d03c0b7a676d08fb2fb1e321133c9f5363fc > > Diff: https://reviews.apache.org/r/56376/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
