----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review164884 -----------------------------------------------------------
Ship it! LGTM (no new tests though) include/mesos/mesos.proto (line 1986) <https://reviews.apache.org/r/56052/#comment236730> And if key is left out, then the entire secret contents are returned/used? include/mesos/mesos.proto (line 1994) <https://reviews.apache.org/r/56052/#comment236731> Why is this optional? Forward-looking for proto3? I can't imagine any use for a Value secret without a value. Optional could still be useful if we eventually decide to replace `string text` with a different type - Adam B On Feb. 8, 2017, 10:33 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56052/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2017, 10:33 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod > Kone. > > > Bugs: MESOS-6996 > https://issues.apache.org/jira/browse/MESOS-6996 > > > Repository: mesos > > > Description > ------- > > This patch adds a new `Secret` protobuf message which > is designed to serve as a generic mechanism for passing > priviledged information within Mesos. > > > Diffs > ----- > > include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a > include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 > > Diff: https://reviews.apache.org/r/56052/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
