> On Feb. 14, 2017, 10:49 p.m., Albert Strasheim wrote: > > include/mesos/mesos.proto, line 1994 > > <https://reviews.apache.org/r/56052/diff/3/?file=1628247#file1628247line1994> > > > > I believe pretty strongly that this should be bytes. Discussed with > > Greg. > > > > If I put bytes into a secret, I want to get bytes out. > > > > If my secret has a bunch of null bytes in the middle of it, it might > > not be suitable for passing to the task as an env var, and I should use a > > file instead. > > > > I shouldn't have to change my app or write a script to transform > > secrets values.
Changed the `Value` message to contain a single required field of type `bytes`. In the patch following this one, which adds a `Secret` to the `Environment` message, I've added validation code which returns an error when a secret value containing a null byte is placed in the environment. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165587 ----------------------------------------------------------- On Feb. 15, 2017, 10:48 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56052/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 10:48 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod > Kone. > > > Bugs: MESOS-6996 > https://issues.apache.org/jira/browse/MESOS-6996 > > > Repository: mesos > > > Description > ------- > > This patch adds a new `Secret` protobuf message which > is designed to serve as a generic mechanism for passing > priviledged information within Mesos. > > > Diffs > ----- > > include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a > include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 > src/common/validation.hpp 7946f06cf17c05893ff80179c9d14b5f1f4023ef > src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 > src/tests/slave_validation_tests.cpp > 3d17799ed04951fb56524db0f5d89347192300b2 > > Diff: https://reviews.apache.org/r/56052/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
