----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56601/#review165502 -----------------------------------------------------------
Fix it, then Ship it! I think that we should also update `checks/checker.cpp` and `checks/health_checker.cpp`: ``` $ ag --cpp --nomultiline '^\s*[^/"]+".*`' checks/checker.cpp 60: "Check's `CommandInfo` is invalid: " + error->message); checks/health_checker.cpp 1111: "Health check's `CommandInfo` is invalid: " + error->message); ``` src/master/validation.cpp (line 339) <https://reviews.apache.org/r/56601/#comment237341> I guess you also want to use single quotes here. src/master/validation.cpp (line 770) <https://reviews.apache.org/r/56601/#comment237342> ditto src/master/validation.cpp (line 961) <https://reviews.apache.org/r/56601/#comment237343> ditto src/master/validation.cpp (line 1239) <https://reviews.apache.org/r/56601/#comment237344> ditto - Gastón Kleiman On Feb. 14, 2017, 1:47 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56601/ > ----------------------------------------------------------- > > (Updated Feb. 14, 2017, 1:47 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/master/validation.cpp 2bfca95713319a195e43e990cbc2dc5570b89c4e > src/tests/master_validation_tests.cpp > fd1f4a6cf0661351e265e50da1bd6ea04ed13d26 > > Diff: https://reviews.apache.org/r/56601/diff/ > > > Testing > ------- > > make check (OS X) > > > Thanks, > > Benjamin Bannier > >
