> On Feb. 14, 2017, 2:48 p.m., Gastón Kleiman wrote:
> > I think that we should also update `checks/checker.cpp` and
> > `checks/health_checker.cpp`:
> >
> > ```
> > $ ag --cpp --nomultiline '^\s*[^/"]+".*`'
> > checks/checker.cpp
> > 60: "Check's `CommandInfo` is invalid: " + error->message);
> >
> > checks/health_checker.cpp
> > 1111: "Health check's `CommandInfo` is invalid: " +
> > error->message);
> > ```
I didn't intend to make a full sweep in this patch, but rather to address a
single such instance in the reservation validation code I touched.
I believe a full sweep should fix a much larger number of places (in addition
to error messages probably also in e.g., help strings),
$ git grep -n '".*`' | grep -v '^.*\/\/' | grep -E '(cpp:|hpp:)' | wc -l
328
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56601/#review165502
-----------------------------------------------------------
On Feb. 14, 2017, 2:47 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56601/
> -----------------------------------------------------------
>
> (Updated Feb. 14, 2017, 2:47 a.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/validation.cpp 2bfca95713319a195e43e990cbc2dc5570b89c4e
> src/tests/master_validation_tests.cpp
> fd1f4a6cf0661351e265e50da1bd6ea04ed13d26
>
> Diff: https://reviews.apache.org/r/56601/diff/
>
>
> Testing
> -------
>
> make check (OS X)
>
>
> Thanks,
>
> Benjamin Bannier
>
>
