----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56215/#review165696 -----------------------------------------------------------
src/launcher/default_executor.cpp (lines 943 - 970) <https://reviews.apache.org/r/56215/#comment237558> I am not a big fan of adding this helper in all the executors, I'd rather put https://reviews.apache.org/r/56017/ earlier in the chain and use that. src/launcher/default_executor.cpp (line 985) <https://reviews.apache.org/r/56215/#comment237559> If we keep this as-is, then I'd replace `Rewrite` with `Update` or `Overwrite`. - Gastón Kleiman On Feb. 9, 2017, 12:56 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56215/ > ----------------------------------------------------------- > > (Updated Feb. 9, 2017, 12:56 p.m.) > > > Review request for mesos, Gastón Kleiman and Vinod Kone. > > > Bugs: MESOS-6906 > https://issues.apache.org/jira/browse/MESOS-6906 > > > Repository: mesos > > > Description > ------- > > When a new task status update is generated in the executor, we have > to make sure specific data is duplicated from the previous update > to, e.g., avoid shadowing of those data during reconciliation. For > instance, consider a check status being sent; in this status update > we must include the latest known health information. > > > Diffs > ----- > > src/launcher/default_executor.cpp e63cf153831088851863d0956455a024e9bc172a > > Diff: https://reviews.apache.org/r/56215/diff/ > > > Testing > ------- > > See https://reviews.apache.org/r/56218/ > > > Thanks, > > Alexander Rukletsov > >
