----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56052/#review165843 -----------------------------------------------------------
src/common/validation.cpp (line 113) <https://reviews.apache.org/r/56052/#comment237676> Please include `<stout/unreachable.hpp>`. - Jan Schlicht On Feb. 15, 2017, 11:48 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56052/ > ----------------------------------------------------------- > > (Updated Feb. 15, 2017, 11:48 p.m.) > > > Review request for mesos, Adam B, Jie Yu, Kapil Arya, Jan Schlicht, and Vinod > Kone. > > > Bugs: MESOS-6996 > https://issues.apache.org/jira/browse/MESOS-6996 > > > Repository: mesos > > > Description > ------- > > This patch adds a new `Secret` protobuf message which > is designed to serve as a generic mechanism for passing > priviledged information within Mesos. > > > Diffs > ----- > > include/mesos/mesos.proto 34a288b6f5c2fca090a7aa7a61798e3255d6663a > include/mesos/v1/mesos.proto 6638111d10f4a36cdf91dfce1019871e9839c306 > src/common/validation.hpp 7946f06cf17c05893ff80179c9d14b5f1f4023ef > src/common/validation.cpp 0f1a02286d8431acfee6136e8ada49b0ac746897 > src/tests/slave_validation_tests.cpp > 3d17799ed04951fb56524db0f5d89347192300b2 > > Diff: https://reviews.apache.org/r/56052/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Greg Mann > >
