> On Feb. 17, 2017, 7:41 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp, lines 1416-1417 > > <https://reviews.apache.org/r/56778/diff/1/?file=1638241#file1638241line1416> > > > > hmm. why didn't you just start with a v1::ExecutorInfo like you did > > with v1::TaskGroup?
Mostly to be consistent with the other tests in the file. Would do a sweep later. > On Feb. 17, 2017, 7:41 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp, line 1317 > > <https://reviews.apache.org/r/56778/diff/1/?file=1638241#file1638241line1317> > > > > Is this still needed? Thought we allowed implicit roles now? good catch, I copy/pasted it from the reservation tests. Would fix it here and thereafter need to do a sweep there too. > On Feb. 17, 2017, 7:41 p.m., Vinod Kone wrote: > > src/tests/default_executor_tests.cpp, lines 1324-1335 > > <https://reviews.apache.org/r/56778/diff/1/?file=1638241#file1638241line1324> > > > > move this to #1380 All the other tests in this file are consistent with doing it here though. Would do a sweep. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/#review165959 ----------------------------------------------------------- On Feb. 17, 2017, 5:24 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56778/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 5:24 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7137 > https://issues.apache.org/jira/browse/MESOS-7137 > > > Repository: mesos > > > Description > ------- > > We were not unallocating the resources before checking if the > executor resources were contained in the checkpointed resources > on the agent. > > > Diffs > ----- > > src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5 > src/tests/default_executor_tests.cpp > ffb69e9d6745c267704195056500edd4d8a4ca3f > > Diff: https://reviews.apache.org/r/56778/diff/ > > > Testing > ------- > > make check + added test that fails without the change. > > > Thanks, > > Anand Mazumdar > >
