----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56778/#review165990 -----------------------------------------------------------
@anand, can you follow up on fixing the tests? src/tests/default_executor_tests.cpp (lines 1321 - 1326) <https://reviews.apache.org/r/56778/#comment237864> Consistently using v1? src/tests/default_executor_tests.cpp (line 1388) <https://reviews.apache.org/r/56778/#comment237861> Ditto. src/tests/default_executor_tests.cpp (lines 1391 - 1392) <https://reviews.apache.org/r/56778/#comment237860> Why we still use evolve here? I think we already support v1::createTask? - Jie Yu On Feb. 17, 2017, 8:15 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56778/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 8:15 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7137 > https://issues.apache.org/jira/browse/MESOS-7137 > > > Repository: mesos > > > Description > ------- > > We were not unallocating the resources before checking if the > executor resources were contained in the checkpointed resources > on the agent. > > > Diffs > ----- > > src/slave/slave.cpp ebba8e16bc9ec45781183e78cb5a3c351a5f65f5 > src/tests/default_executor_tests.cpp > ffb69e9d6745c267704195056500edd4d8a4ca3f > > Diff: https://reviews.apache.org/r/56778/diff/ > > > Testing > ------- > > make check + added test that fails without the change. > > > Thanks, > > Anand Mazumdar > >
