> On Feb. 21, 2017, 1:50 p.m., Vinod Kone wrote: > > include/mesos/mesos.proto, line 1558 > > <https://reviews.apache.org/r/56830/diff/1/?file=1640428#file1640428line1558> > > > > s/On//
I think `OnTerminationPolicy` looks ugly not because of `On` but rather it's a three word term which is a bit mouthful. `OnTermination` or `OnTerminate` by itself is widely used in similar contexts. I started to wonder if the word `Policy` add much additional info. The protobuf is clearly about how to **handle** (i.e., **action** to take on) termination. Maybe none of these words are necessary? - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56830/#review166233 ----------------------------------------------------------- On Feb. 19, 2017, 9 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56830/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2017, 9 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-7067 > https://issues.apache.org/jira/browse/MESOS-7067 > > > Repository: mesos > > > Description > ------- > > Describes the on termination policy associated with a task and is > applied upon a task termination. > > > Diffs > ----- > > include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d > include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574 > > Diff: https://reviews.apache.org/r/56830/diff/ > > > Testing > ------- > > make check (tests later in the chain) > > > Thanks, > > Anand Mazumdar > >
