----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56830/#review166255 -----------------------------------------------------------
include/mesos/mesos.proto (lines 1641 - 1642) <https://reviews.apache.org/r/56830/#comment238169> I think for our protos we pretty much follow the rule to define the nested message right above where it's used (If its use is singular). e.g., Resource. Any reason to define it at the top? - Jiang Yan Xu On Feb. 19, 2017, 9 p.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56830/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2017, 9 p.m.) > > > Review request for mesos, Vinod Kone and Jiang Yan Xu. > > > Bugs: MESOS-7067 > https://issues.apache.org/jira/browse/MESOS-7067 > > > Repository: mesos > > > Description > ------- > > Describes the on termination policy associated with a task and is > applied upon a task termination. > > > Diffs > ----- > > include/mesos/mesos.proto 030e79c003f6560e9c0627db12fb1baba411151d > include/mesos/v1/mesos.proto 7f6f858a7d9387d202510730d400e490298e6574 > > Diff: https://reviews.apache.org/r/56830/diff/ > > > Testing > ------- > > make check (tests later in the chain) > > > Thanks, > > Anand Mazumdar > >
