----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55543/#review166000 -----------------------------------------------------------
Ship it! This change LGTM, but I'll need to update `support/windows-build.bat` and `docs/windows.md` with some tweaked instructions. That script/doc currently doesn't set the environment variable, but calls `msbuild` with the `PreferredToolArchitecture` argument set. - Joseph Wu On Feb. 11, 2017, 5:08 p.m., Alex Clemmer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55543/ > ----------------------------------------------------------- > > (Updated Feb. 11, 2017, 5:08 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu. > > > Bugs: MESOS-6720 > https://issues.apache.org/jira/browse/MESOS-6720 > > > Repository: mesos > > > Description > ------- > > Before building Mesos on a Windows machine, it is necessary to set > `%PreferredToolArchitecture%` to the value `x64`. This is necessary to > work around (at least) two bugs in the MSVC backend: in particular, the > linker can sometimes take hours or days to link `mesos-x.x.x.lib`, and > the build system occasionally finds it self spuriously unable to find > file `mesos-x.x.x.lib` to link against. > > These issues are well-known and documented (e.g., in the official Mesos > "getting started" document), but it is better to simply refuse to build > Mesos at all on Windows unless that environment variable is set. > > This commit will introduce such a check. > > > Diffs > ----- > > cmake/CompilationConfigure.cmake 560935b81603dc58c167918d36e2ae0a4060673d > src/CMakeLists.txt 3a4ace9c8011ac8eec5067cd085fa7fe4166b9ee > src/slave/cmake/AgentConfigure.cmake > 8d930d329048440d57b621fe8393b11912cdb27b > > Diff: https://reviews.apache.org/r/55543/diff/ > > > Testing > ------- > > > Thanks, > > Alex Clemmer > >
