----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57109/#review167758 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.hpp Lines 416-417 (patched) <https://reviews.apache.org/r/57109/#comment239720> How about `executorsToRecheckpoint` and `tasksToRecheckpoint`? src/slave/slave.hpp Lines 1062 (patched) <https://reviews.apache.org/r/57109/#comment239721> maybe `recheckpointExecutor`? src/slave/slave.hpp Lines 1063 (patched) <https://reviews.apache.org/r/57109/#comment239722> Ditto here. src/slave/slave.cpp Lines 6973 (patched) <https://reviews.apache.org/r/57109/#comment239723> Should we put this after the checkpoint call so that the ownership is a little more clear? - Benjamin Mahler On March 2, 2017, 9:48 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57109/ > ----------------------------------------------------------- > > (Updated March 2, 2017, 9:48 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-7061 > https://issues.apache.org/jira/browse/MESOS-7061 > > > Repository: mesos > > > Description > ------- > > Re-checkpointed the `Executor`s and `Task`s during agent recovery. > > > Diffs > ----- > > src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83 > src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b > > > Diff: https://reviews.apache.org/r/57109/diff/2/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
