> On March 2, 2017, 3:11 p.m., Benjamin Mahler wrote:
> > src/slave/slave.hpp
> > Lines 1062 (patched)
> > <https://reviews.apache.org/r/57109/diff/2/?file=1654025#file1654025line1062>
> >
> >     maybe `recheckpointExecutor`?

Took this recommendation and also updated to `recheckpointTask`.


> On March 2, 2017, 3:11 p.m., Benjamin Mahler wrote:
> > src/slave/slave.cpp
> > Lines 6973 (patched)
> > <https://reviews.apache.org/r/57109/diff/2/?file=1654026#file1654026line6976>
> >
> >     Should we put this after the checkpoint call so that the ownership is a 
> > little more clear?

Done.


- Michael


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57109/#review167758
-----------------------------------------------------------


On March 3, 2017, 1:12 a.m., Michael Park wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57109/
> -----------------------------------------------------------
> 
> (Updated March 3, 2017, 1:12 a.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-7061
>     https://issues.apache.org/jira/browse/MESOS-7061
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Re-checkpointed the `Executor`s and `Task`s during agent recovery.
> 
> 
> Diffs
> -----
> 
>   src/slave/slave.hpp 449971b6b343c7714e1d1167a55bbdfe94d2cf83 
>   src/slave/slave.cpp 6ae9458cc81a7623a1837cd636156434a972004b 
> 
> 
> Diff: https://reviews.apache.org/r/57109/diff/3/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Michael Park
> 
>

Reply via email to