> On March 2, 2017, 9:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.hpp > > Lines 152-153 (original), 152-153 (patched) > > <https://reviews.apache.org/r/55887/diff/6/?file=1652718#file1652718line152> > > > > If we are keeping the original semantics of `_run`, do we still need to > > change the code here and the tests to capture `__run` instead of `_run` for > > mocking? > > > > The mocking is just used to insert task killings when the task is not > > with the agent actor.
Agreed. The previous iteration of `_run()` and `__run()` required that. Not needed any more. > On March 2, 2017, 9:26 a.m., Jiang Yan Xu wrote: > > src/slave/slave.cpp > > Lines 1830-1840 (original), 1818-1835 (patched) > > <https://reviews.apache.org/r/55887/diff/6/?file=1652719#file1652719line1831> > > > > This results in a behavior change: if tasks are killed during > > unscheduling of directories, we now send TASK_DROPPED instead of > > TASK_KILLED. I think this is a better behavior because this is race anyways > > and the TASK_DROPPED here better reveals the error condition on the host. > > > > Nevertheless we could check with the @anand and @vinod who last changed > > this. I reinstated the original behavior. We can followup with @anand and @vinod later. - Anindya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55887/#review167654 ----------------------------------------------------------- On March 1, 2017, 4:15 p.m., Anindya Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55887/ > ----------------------------------------------------------- > > (Updated March 1, 2017, 4:15 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, and Jiang Yan Xu. > > > Bugs: MESOS-6953 > https://issues.apache.org/jira/browse/MESOS-6953 > > > Repository: mesos > > > Description > ------- > > Added support for action `run_tasks` on the agent's flag `acl`. Based on > the ACL configured for `run_tasks`, a task to be launched on the agent > can be (dis)allowed to launch on the agent. > If a task or task group cannot be launched due to failed authorization, > a `TASK_ERROR` Status Update shall be sent with a reason code of > `REASON_TASK_UNAUTHORIZED` or `REASON_TASK_GROUP_UNAUTHORIZED` as > applicable. > Note that in case of a task group, all tasks fail if any of the tasks > within the task group encounter the authorization error. > > > Diffs > ----- > > src/slave/slave.hpp 3b0aea4e3e9a17501077beccbccaab4abbe11af2 > src/slave/slave.cpp 892ce1938ac695e7913aa9139536d0787f3f5ea7 > src/tests/master_slave_reconciliation_tests.cpp > 1c7a3d686e2f924ad14c75fcab2ccafaab6d7b81 > src/tests/mock_slave.hpp 1acb961b642e1e0b4677db7b8fc6150d480eb751 > src/tests/mock_slave.cpp 50c04bff9e6f0f202af4c07b4036e021d3833ebf > src/tests/slave_tests.cpp 3731c7607d5e49f3000c4863b1999851fac45705 > > > Diff: https://reviews.apache.org/r/55887/diff/6/ > > > Testing > ------- > > All tests passed. > > > Thanks, > > Anindya Sinha > >
