> On March 3, 2017, 8:48 a.m., Greg Mann wrote: > > src/authentication/executor/jwt_secret_generator.hpp > > Lines 40 (patched) > > <https://reviews.apache.org/r/56754/diff/4/?file=1651715#file1651715line40> > > > > Use `override` instead of `virtual` here?
Do we use that for destructors as well? Seems uncommon in that context and haven't seen any examples in our source base. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review167735 ----------------------------------------------------------- On Feb. 28, 2017, 2:39 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56754/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2017, 2:39 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7000 > https://issues.apache.org/jira/browse/MESOS-7000 > > > Repository: mesos > > > Description > ------- > > This can be used to create a 'Secret' from an 'AuthenticationContext'. > The resulting secret will provide a JWT. > > > Diffs > ----- > > src/Makefile.am 76d58a0bbd77fe59ff8a81ba7a68c84dc7169750 > src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION > src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION > src/tests/secret_generator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56754/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
