> On March 7, 2017, 7:55 p.m., Greg Mann wrote: > > src/tests/secret_generator_tests.cpp > > Lines 55 (patched) > > <https://reviews.apache.org/r/56754/diff/7/?file=1658292#file1658292line55> > > > > Is the `Option<string>::none()` necessary? I think the `value` member > > would be default-initialized to `NONE`? > > Jan Schlicht wrote: > `Principal` doesn't have a default constructor.
Ohh that's right, I forgot that I had deleted it, sorry! :) - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56754/#review168175 ----------------------------------------------------------- On March 8, 2017, 2:26 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56754/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 2:26 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7000 > https://issues.apache.org/jira/browse/MESOS-7000 > > > Repository: mesos > > > Description > ------- > > This can be used to create a 'Secret' from a 'Principal'. > The resulting secret will provide a JWT. > > > Diffs > ----- > > src/Makefile.am bb917c5d1b36f5106a74914fa3a864038a95e8bb > src/authentication/executor/jwt_secret_generator.hpp PRE-CREATION > src/authentication/executor/jwt_secret_generator.cpp PRE-CREATION > src/tests/secret_generator_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56754/diff/8/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
