----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review168192 -----------------------------------------------------------
3rdparty/libprocess/src/jwt.cpp Lines 120 (patched) <https://reviews.apache.org/r/56667/#comment240355> return JWTError("Failed to generate HMAC signature: " + hmac.error(), JWTError::Type::UNKNOWN); 3rdparty/libprocess/src/jwt.cpp Lines 150-152 (patched) <https://reviews.apache.org/r/56667/#comment240357> the indentation looks like `generate_hmac_sha256` takes 3 args. maybe indent the 2nd line by couple spaces? 3rdparty/libprocess/src/jwt.cpp Lines 155 (patched) <https://reviews.apache.org/r/56667/#comment240358> ditto. Add a prefix to the error message "Failed to generate HMAC signature: " 3rdparty/libprocess/src/jwt.cpp Lines 162-164 (patched) <https://reviews.apache.org/r/56667/#comment240359> fix indentation of args. 3rdparty/libprocess/src/jwt.cpp Lines 173 (patched) <https://reviews.apache.org/r/56667/#comment240362> "Failed to decode: " prefix 3rdparty/libprocess/src/jwt.cpp Lines 179 (patched) <https://reviews.apache.org/r/56667/#comment240363> "Failed to parse into JSON: " prefix 3rdparty/libprocess/src/jwt.cpp Lines 191 (patched) <https://reviews.apache.org/r/56667/#comment240361> s/Could not/Failed to/ 3rdparty/libprocess/src/jwt.cpp Lines 194 (patched) <https://reviews.apache.org/r/56667/#comment240364> s/JOSE/JSON/ ? 3rdparty/libprocess/src/jwt.cpp Lines 202 (patched) <https://reviews.apache.org/r/56667/#comment240367> s/as expected// 3rdparty/libprocess/src/jwt.cpp Lines 221 (patched) <https://reviews.apache.org/r/56667/#comment240366> s/as expected// 3rdparty/libprocess/src/jwt.cpp Lines 254 (patched) <https://reviews.apache.org/r/56667/#comment240365> s/Could not/Failed to/ 3rdparty/libprocess/src/jwt.cpp Lines 282 (patched) <https://reviews.apache.org/r/56667/#comment240369> s/validate/Validate/ 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 50 (patched) <https://reviews.apache.org/r/56667/#comment240370> s/Broken/Invalid/ 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 61 (patched) <https://reviews.apache.org/r/56667/#comment240371> s/Broken/Invalid/ 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 72 (patched) <https://reviews.apache.org/r/56667/#comment240372> s/Wrong/Unsupported/ 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 118 (patched) <https://reviews.apache.org/r/56667/#comment240373> period at the end. here and below. 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 198 (patched) <https://reviews.apache.org/r/56667/#comment240376> can you do EXPECT_SOME? 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 209 (patched) <https://reviews.apache.org/r/56667/#comment240377> ditto. EXPECT_SOME? 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 233 (patched) <https://reviews.apache.org/r/56667/#comment240381> period at the end. here and below. 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 237 (patched) <https://reviews.apache.org/r/56667/#comment240378> EXPECT_SOME? 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 239 (patched) <https://reviews.apache.org/r/56667/#comment240379> jwt->header.alg 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 244 (patched) <https://reviews.apache.org/r/56667/#comment240380> jwt->signature 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 251 (patched) <https://reviews.apache.org/r/56667/#comment240382> EXPECT_SOME? 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 253 (patched) <https://reviews.apache.org/r/56667/#comment240383> jwt->header.alg 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 254 (patched) <https://reviews.apache.org/r/56667/#comment240384> jwt->header.typ 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 256 (patched) <https://reviews.apache.org/r/56667/#comment240385> jwt->payload 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 258 (patched) <https://reviews.apache.org/r/56667/#comment240386> jwt->signature 3rdparty/libprocess/src/tests/jwt_tests.cpp Lines 271 (patched) <https://reviews.apache.org/r/56667/#comment240388> EXPECT_SOME? - Vinod Kone On March 7, 2017, 3:57 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56667/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 3:57 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > JSON Web Tokens can be used to create claim-based access tokens and is > typically used for HTTP authentication. > This implementation is intended for internal use, e.g. Mesos is supposed > to only parse tokens that it also created. It doesn't fully comply with > RFC 7519. Currently the only supported cryptographic algorithm is HMAC > with SHA-256. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION > 3rdparty/libprocess/src/jwt.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56667/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
