> On March 7, 2017, 10:37 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/jwt.cpp > > Lines 194 (patched) > > <https://reviews.apache.org/r/56667/diff/7/?file=1658327#file1658327line194> > > > > s/JOSE/JSON/ ? > > Greg Mann wrote: > Strangely, "JOSE header" just happens to be the name of the JWT header: > https://tools.ietf.org/html/rfc7519#section-5
Yes, that's not a typo, the header of a JWT is a JOSE header. Definition from [RFC 7515](https://tools.ietf.org/html/rfc7515#section-2): "JSON object containing the parameters describing the cryptographic operations and parameters employed. The JOSE (JSON Object Signing and Encryption) Header is comprised of a set of Header Parameters.". > On March 7, 2017, 10:37 p.m., Vinod Kone wrote: > > 3rdparty/libprocess/src/tests/jwt_tests.cpp > > Lines 198 (patched) > > <https://reviews.apache.org/r/56667/diff/7/?file=1658328#file1658328line198> > > > > can you do EXPECT_SOME? Unfortunately not, because `EXPECT_SOME` only works with a `Try<T>`, not with `Try<T,E>` where `E != Error`. It doesn't matter here that `JWTError` inherits from `Error`, some template metaprogramming is restricting this. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56667/#review168192 ----------------------------------------------------------- On March 7, 2017, 4:57 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56667/ > ----------------------------------------------------------- > > (Updated March 7, 2017, 4:57 p.m.) > > > Review request for mesos, Alexander Rojas and Greg Mann. > > > Bugs: MESOS-7001 > https://issues.apache.org/jira/browse/MESOS-7001 > > > Repository: mesos > > > Description > ------- > > JSON Web Tokens can be used to create claim-based access tokens and is > typically used for HTTP authentication. > This implementation is intended for internal use, e.g. Mesos is supposed > to only parse tokens that it also created. It doesn't fully comply with > RFC 7519. Currently the only supported cryptographic algorithm is HMAC > with SHA-256. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am 75386184108214e67a58c328258ec204099d638c > 3rdparty/libprocess/include/process/jwt.hpp PRE-CREATION > 3rdparty/libprocess/src/jwt.cpp PRE-CREATION > 3rdparty/libprocess/src/tests/jwt_tests.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/56667/diff/7/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
