> On March 8, 2017, 5:30 p.m., Michael Park wrote: > > 3rdparty/stout/include/stout/os/windows/stat.hpp > > Line 112 (original), 119-121 (patched) > > <https://reviews.apache.org/r/56028/diff/1/?file=1617904#file1617904line128> > > > > Do we not also want to error out here? > > ```cpp > > if (follow == DO_NOT_FOLLOW_SYMLINK) { > > return WindowsError( > > ERROR_NOT_SUPPORTED, > > "Error invoking stat for '" + path + "'"); > > } > > ```
This function handles symlinks already, so I made a slightly different change. Since I can't build or test Windows, I tried to minimize this change :) - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review168313 ----------------------------------------------------------- On March 8, 2017, 10:39 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56028/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 10:39 p.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, > Michael Park, and Jiang Yan Xu. > > > Bugs: MESOS-7021 > https://issues.apache.org/jira/browse/MESOS-7021 > > > Repository: mesos > > > Description > ------- > > Consistently add the FollowSymlink stat argument on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/stat.hpp > e7440a4dab82ca3758a60a8fdc859476b2ee5693 > 3rdparty/stout/include/stout/os/stat.hpp > 5c4fd4e630459059fa94c9f98e0d9b73d1280918 > 3rdparty/stout/include/stout/os/windows/stat.hpp > e7f471b828d96bb5cd01823dd78c8570730712ea > > > Diff: https://reviews.apache.org/r/56028/diff/2/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
