----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56028/#review168535 -----------------------------------------------------------
3rdparty/stout/include/stout/os/windows/stat.hpp Lines 41-43 (patched) <https://reviews.apache.org/r/56028/#comment240775> Don't use `WindowsError` here, as you'll give the impression this is a Windows API error. Normal `Error` + a normal message will suffice. Ditto on the below. - Joseph Wu On March 8, 2017, 4:42 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56028/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 4:42 p.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, > Michael Park, and Jiang Yan Xu. > > > Bugs: MESOS-7021 > https://issues.apache.org/jira/browse/MESOS-7021 > > > Repository: mesos > > > Description > ------- > > Consistently add the FollowSymlink stat argument on Windows. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/windows/stat.hpp > e7f471b828d96bb5cd01823dd78c8570730712ea > > > Diff: https://reviews.apache.org/r/56028/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
