----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56027/#review168359 -----------------------------------------------------------
3rdparty/stout/include/stout/os/stat.hpp Lines 20-21 (patched) <https://reviews.apache.org/r/56027/#comment240574> Updated the comment to make it clearer that we are talking about how this is used in the `os::stat` API family. 3rdparty/stout/include/stout/os/stat.hpp Lines 21-22 (patched) <https://reviews.apache.org/r/56027/#comment240576> This is trying to document that the flag only means that we use te O_NOFOLLOW flag. The semantics of this are that it doesn't follow the last path component if that is a symlink. Intermediate path symlinks are always followed. I removed the comment, since it probably raises more questions than answers. - James Peach On Feb. 2, 2017, 12:46 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56027/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2017, 12:46 a.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, > Michael Park, and Jiang Yan Xu. > > > Bugs: MESOS-7021 > https://issues.apache.org/jira/browse/MESOS-7021 > > > Repository: mesos > > > Description > ------- > > Consistently add the FollowSymlink stat argument on POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/stat.hpp > e7440a4dab82ca3758a60a8fdc859476b2ee5693 > 3rdparty/stout/include/stout/os/stat.hpp > 5c4fd4e630459059fa94c9f98e0d9b73d1280918 > > > Diff: https://reviews.apache.org/r/56027/diff/1/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
