----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56027/#review168513 -----------------------------------------------------------
Fix it, then Ship it! Looks good! Just a few nit-picks below. 3rdparty/stout/include/stout/os/posix/stat.hpp Lines 62 (patched) <https://reviews.apache.org/r/56027/#comment240751> I would prefer this: ``` return s.isSome() && S_ISLNK(s->st_mode); ``` Here and below. What do you think? 3rdparty/stout/include/stout/os/posix/stat.hpp Line 84 (original), 93 (patched) <https://reviews.apache.org/r/56027/#comment240753> Remove newline. Similar situations below. - Michael Park On March 8, 2017, 4:41 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56027/ > ----------------------------------------------------------- > > (Updated March 8, 2017, 4:41 p.m.) > > > Review request for mesos, Alex Clemmer, Joris Van Remoortere, Joseph Wu, > Michael Park, and Jiang Yan Xu. > > > Bugs: MESOS-7021 > https://issues.apache.org/jira/browse/MESOS-7021 > > > Repository: mesos > > > Description > ------- > > Consistently add the FollowSymlink stat argument on POSIX. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/posix/stat.hpp > e7440a4dab82ca3758a60a8fdc859476b2ee5693 > 3rdparty/stout/include/stout/os/stat.hpp > 5c4fd4e630459059fa94c9f98e0d9b73d1280918 > > > Diff: https://reviews.apache.org/r/56027/diff/4/ > > > Testing > ------- > > make check (Fedora 25) > > > Thanks, > > James Peach > >
