----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57646/#review169133 -----------------------------------------------------------
src/checks/health_checker.cpp Line 497 (original), 500 (patched) <https://reviews.apache.org/r/57646/#comment241452> responding with src/checks/health_checker.cpp Lines 506 (patched) <https://reviews.apache.org/r/57646/#comment241460> Why is that you can't discard a future inside a continuation? Do you mean because continuations take a const ref? If so, you can just make a copy to discard; we use that pattern elsewhere (see `detection` future in slave.cpp). of course calling `future.discard()` doesn't complete the future but calls its onDiscard() (note: not onDiscar*ded*()) callback. (although looking at `detection` in slave.cpp, i'm now confused why discarding the future results in onAny callback being called.) - Vinod Kone On March 15, 2017, 2:59 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57646/ > ----------------------------------------------------------- > > (Updated March 15, 2017, 2:59 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > See the summary. > > > Diffs > ----- > > src/checks/health_checker.hpp f1f2834b3429fb00cc49c179fa9a3de328f597b5 > src/checks/health_checker.cpp 6c97369fd9a567ba16dd92085bf142d43f71eaf1 > > > Diff: https://reviews.apache.org/r/57646/diff/1/ > > > Testing > ------- > > `make check` in Linux > > > Thanks, > > Gastón Kleiman > >
