> On March 22, 2017, 4:37 p.m., Alexander Rukletsov wrote: > > src/checks/health_checker.cpp > > Lines 681-684 (patched) > > <https://reviews.apache.org/r/57646/diff/2/?file=1670858#file1670858line693> > > > > This comment includes non-local information which tends to become > > stale. Instead, how about we simply return `Failure(failure)` here and > > remove the comment? > > Gastón Kleiman wrote: > If you do this, then the return will trigger the `onFailure` callback > that discards the `Promise`. =/
Oh, right. How about returning `future` then? - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57646/#review169714 ----------------------------------------------------------- On March 22, 2017, 6:19 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57646/ > ----------------------------------------------------------- > > (Updated March 22, 2017, 6:19 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent > huang, and Vinod Kone. > > > Bugs: MESOS-6280 > https://issues.apache.org/jira/browse/MESOS-6280 > > > Repository: mesos > > > Description > ------- > > Made COMMAND health checks resilient to agent failovers. > > > Diffs > ----- > > src/checks/health_checker.hpp 44df544b585b8c9f1138fc69b34b064bae8cc867 > src/checks/health_checker.cpp a26e9b570ea3a0ee775d220a3b523ae7052dad23 > > > Diff: https://reviews.apache.org/r/57646/diff/3/ > > > Testing > ------- > > `make check` in Linux > > > Thanks, > > Gastón Kleiman > >
