----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/#review169233 -----------------------------------------------------------
Hm.. there is no way for weights to be removed from the sorter? Is that intentional? If there is some non-local reasoning needed to understand why, it would be great to document it. Also, could we perhaps title this change as removing unnecessary weight storage in the allocator and why it's not necessary? I think in general we don't want to use the sorter for management of configuration (which is what the summary/description sounds like). Fortunately, this change doesn't have the allocator using the sorters as a weight storage mechanism, so it seems ok. - Benjamin Mahler On March 11, 2017, 1:51 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57527/ > ----------------------------------------------------------- > > (Updated March 11, 2017, 1:51 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Previously, DRFSorter only kept track of weights for clients currently > in the sorter; the allocator supplied the current weight when adding a > client to the sorter. > > This commit changes the sorter to keep track of all weights; the > allocator can now just pass along role weights to the role sorters, > rather than needing to track them itself. > > This commit changes the sorter API. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > f84b0574ce9a392c9528c87b04b01dbb2053cff7 > src/master/allocator/mesos/hierarchical.cpp > 37fb7a62ef95c2f6e5a9e9a4ab49260332e2b03b > src/master/allocator/sorter/drf/sorter.hpp > 76329220e1115c1de7810fb69b943c78c078be59 > src/master/allocator/sorter/drf/sorter.cpp > ed54680cecb637931fc344fbcf8fd3b14cc24295 > src/master/allocator/sorter/sorter.hpp > b3029fcf7342406955760da53f1ae736769f308c > src/tests/sorter_tests.cpp ec0636beb936d46a253d19322f2157abe95156b6 > > > Diff: https://reviews.apache.org/r/57527/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
