> On March 17, 2017, 12:42 a.m., Benjamin Mahler wrote: > > Hm.. there is no way for weights to be removed from the sorter? Is that > > intentional? If there is some non-local reasoning needed to understand why, > > it would be great to document it. > > > > Also, could we perhaps title this change as removing unnecessary weight > > storage in the allocator and why it's not necessary? I think in general we > > don't want to use the sorter for management of configuration (which is what > > the summary/description sounds like). Fortunately, this change doesn't have > > the allocator using the sorters as a weight storage mechanism, so it seems > > ok.
It would be possible to add support for removing weights from the sorter, but that functionality isn't required right now, so I didn't bother implementing it (you'd have to add support for removing weights to the allocator interface first, for one thing). I added a comment explaining this -- let me know if that sounds good. I revised the commit message -- let me know what you think. - Neil ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57527/#review169233 ----------------------------------------------------------- On March 17, 2017, 1:12 a.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57527/ > ----------------------------------------------------------- > > (Updated March 17, 2017, 1:12 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Previously, DRFSorter only kept track of weights for clients currently > in the sorter; the allocator supplied the current weight when adding a > client to the sorter. > > This commit changes the sorter to keep track of all weights, not just > those for the active clients in the sorter. The allocator can now just > pass along role weights to the role sorters, rather than needing to > track them itself. > > This commit changes the sorter API. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.hpp > f84b0574ce9a392c9528c87b04b01dbb2053cff7 > src/master/allocator/mesos/hierarchical.cpp > 8d54a8cca1bb478f4437f68c5e14f66a9f9bb9e9 > src/master/allocator/sorter/drf/sorter.hpp > 76329220e1115c1de7810fb69b943c78c078be59 > src/master/allocator/sorter/drf/sorter.cpp > ed54680cecb637931fc344fbcf8fd3b14cc24295 > src/master/allocator/sorter/sorter.hpp > b3029fcf7342406955760da53f1ae736769f308c > src/tests/sorter_tests.cpp ec0636beb936d46a253d19322f2157abe95156b6 > > > Diff: https://reviews.apache.org/r/57527/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Neil Conway > >
